Build dockers #1298

rbanka1 · 2025-05-06T15:26:57Z

Added UMF docker

This is the first part only for docker build. The second with updated CI : #1329

// workflow executed on fork:
https://github.com/rbanka1/unified-memory-framework/actions/runs/15134054789
https://github.com/rbanka1/unified-memory-framework/actions/runs/15134054814

I added a new Docker image for Ubuntu 24.04 and updated the others.
I also created two new workflows that check for changes in the Docker files.
If any changes are detected, the relevant Docker image will be rebuilt and pushed (unless it's a pull request).
The rebuilt images will be available after the merge.

KFilipek · 2025-05-07T13:17:07Z

@lukaszstolarczuk
We have https://github.com/bb-umf account on GitHub.

.github/docker/ubuntu-20.04.Dockerfile

.github/workflows/reusable_basic.yml

.github/docker/ubuntu-20.04.Dockerfile

.github/docker/ubuntu-22.04.Dockerfile

.github/docker/ubuntu-20.04.Dockerfile

.github/workflows/reusable_basic.yml

lukaszstolarczuk · 2025-05-14T11:14:53Z

.github/workflows/reusable_basic.yml

@@ -192,7 +166,6 @@ jobs:
        -DUMF_DISABLE_HWLOC=${{matrix.disable_hwloc}}
        -DUMF_LINK_HWLOC_STATICALLY=${{matrix.link_hwloc_statically}}
        ${{ matrix.build_type == 'Debug' && matrix.compiler.c == 'gcc' && '-DUMF_USE_COVERAGE=ON' || '' }}
-        ${{ matrix.llvm_linker || '' }}


why this is removed?

.github/workflows/reusable_basic.yml

.github/docker/ubuntu-20.04.Dockerfile

.github/docker/ubuntu-22.04.Dockerfile

lukaszstolarczuk · 2025-05-21T13:38:38Z

.github/workflows/pr_push.yml


 jobs:
  CodeChecks:
    uses: ./.github/workflows/reusable_checks.yml
  FastBuild:
-    name: Fast builds


why the name was removed?

lukaszstolarczuk · 2025-05-21T13:39:22Z

.github/workflows/detect_changes.yml

+        run: |
+          echo "Changed files: $ALL_CHANGED_FILES"
+
+  RunReusableDocker:


perhaps simply BuildDocker

lukaszstolarczuk · 2025-05-21T13:40:53Z

.github/workflows/reusable_basic.yml

    strategy:
      matrix:
-        os: ['ubuntu-22.04', 'ubuntu-24.04']
+        ubuntu_ver: ['ubuntu-22.04', 'ubuntu-24.04']


we should probably go back to the os name, as it contains not only the ubu ver

lukaszstolarczuk · 2025-05-21T13:43:54Z

.github/workflows/reusable_basic.yml

-    - name: Install g++-7
-      if: matrix.compiler.cxx == 'g++-7'
-      run: sudo apt-get install -y ${{matrix.compiler.cxx}}
+        echo "${USERPASS}" | sudo -Sk bash -c "


some as above, perhaps sudo su

I wrote installation script to avoid multi-line bash command

lukaszstolarczuk · 2025-05-21T13:45:06Z

.github/workflows/reusable_dockers_build.yml

+    runs-on: ubuntu-latest
+    strategy: 
+      matrix:
+        ubuntu-version: [20.04, 22.04, 24.04]


I believe for unity, this should also be os (full name of the distro)

lukaszstolarczuk · 2025-05-21T13:46:53Z

.github/workflows/reusable_fast.yml

    strategy:
      matrix:
        include:
-          - os: windows-latest
+          - ubuntu_ver: ubuntu-22.04


same - re-name to os please

lukaszstolarczuk · 2025-05-21T14:00:45Z

.github/docker/ubuntu-24.04.Dockerfile

+	build-essential \
+	cmake \
+	git \
+	gnupg"


then it should be moved to oneapi installation step

(applies to both docker files)

lukaszstolarczuk · 2025-05-21T14:02:01Z

.github/workflows/reusable_basic.yml

-        ${{ matrix.install_tbb == 'ON' && matrix.disable_hwloc != 'ON' && matrix.shared_library == 'ON' && '--proxy' || '' }}
-        --umf-version ${{env.UMF_VERSION}}
-        ${{ matrix.shared_library == 'ON' && '--shared-library' || '' }}
+    # - name: Test UMF installation and uninstallation


and I believe it's the time to uncomment this - what's failing with that? please send me a link and we'll investigate...

not necessary, it is working :)

lukaszstolarczuk

the CI is failing unfortunately - is it possible that it needs some of the fixes in docker that wasn't pushed yet?

perhaps you should split your PR into 2 - one with docker changes, and the other with the rest...?

lukaszstolarczuk · 2025-05-22T14:31:45Z

.github/workflows/detect_changes.yml

+on:
+  pull_request:
+    paths:
+      - '.github/docker/*.Dockerfile'


.github/scripts dir should be added as well

not done yet

why? I added the path

Where? It is added on push, but on pull_request it is missing:

oh sorry, now it is done

lukaszstolarczuk · 2025-05-22T14:34:22Z

.github/workflows/reusable_basic.yml

@@ -28,7 +35,7 @@ jobs:
        link_hwloc_statically: ['OFF']
        cmake_ver: ['default']
        include:
-          - os: 'ubuntu-22.04'
+          - os: ubuntu-22.04


sry for being meticulous, but you could leave ' as they were here before... we'll potentially have less conflicts on any merges, and less changes here

.github/docker/ubuntu-20.04.Dockerfile

ldorau · 2025-05-27T12:23:41Z

CONTRIBUTING.md

+If you want to rebuild existing Docker images or add a new one, you must open a separate pull 
+request dedicated to Docker-related changes. This PR must be merged into the main branch first.
+
+Only after the PR is merged will the updated Docker images be available for use in workflows.


"The updated Docker images will be available for use in workflows only when this PR is merged."

I added a new Docker image for Ubuntu 24.04 and updated the others. I also created two new workflows that check for changes in the Docker files. If any changes are detected, the relevant Docker image will be rebuilt and pushed (unless it's a pull request). The rebuilt images will be available after the merge.

KFilipek requested changes May 8, 2025

View reviewed changes

.github/docker/ubuntu-20.04.Dockerfile Outdated Show resolved Hide resolved

.github/docker/ubuntu-20.04.Dockerfile Show resolved Hide resolved

.github/workflows/reusable_basic.yml Outdated Show resolved Hide resolved

lukaszstolarczuk mentioned this pull request May 8, 2025

Docker workflow #1105

Closed

10 tasks

rbanka1 force-pushed the newDocker branch 2 times, most recently from 6039c67 to b1d2ec2 Compare May 13, 2025 11:58

lukaszstolarczuk reviewed May 14, 2025

View reviewed changes

rbanka1 changed the title ~~New docker UMF~~ Add dockers to Fast and Basic Builds May 15, 2025

rbanka1 force-pushed the newDocker branch 5 times, most recently from 3552ecc to aefd38a Compare May 20, 2025 10:43

lukaszstolarczuk requested changes May 21, 2025

View reviewed changes

rbanka1 force-pushed the newDocker branch 4 times, most recently from f15cda9 to 5705c2a Compare May 22, 2025 14:01

lukaszstolarczuk reviewed May 22, 2025

View reviewed changes

rbanka1 force-pushed the newDocker branch from 1200a74 to 941e435 Compare May 23, 2025 20:07

rbanka1 changed the title ~~Add dockers to Fast and Basic Builds~~ Build dockers May 23, 2025

rbanka1 force-pushed the newDocker branch from 92ac4f6 to 941e435 Compare May 23, 2025 20:26

rbanka1 marked this pull request as ready for review May 23, 2025 20:32

rbanka1 requested a review from a team as a code owner May 23, 2025 20:32

KFilipek approved these changes May 26, 2025

View reviewed changes

.github/docker/ubuntu-20.04.Dockerfile Show resolved Hide resolved

ldorau reviewed May 27, 2025

View reviewed changes

rbanka1 force-pushed the newDocker branch from 941e435 to 9b1fcb9 Compare May 28, 2025 13:23

Build dockers #1298

Are you sure you want to change the base?

Build dockers #1298

Uh oh!

Conversation

rbanka1 commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KFilipek commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukaszstolarczuk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

rbanka1 commented May 6, 2025 •

edited

Loading

KFilipek commented May 7, 2025 •

edited

Loading